Skip to content
Snippets Groups Projects
Commit cc4646a6 authored by Tor-Einar Skog's avatar Tor-Einar Skog
Browse files

A bit of refactoring

parent 16de62aa
No related branches found
No related tags found
No related merge requests found
...@@ -81,11 +81,11 @@ public class DeliaRadicumModel extends I18nImpl implements Model{ ...@@ -81,11 +81,11 @@ public class DeliaRadicumModel extends I18nImpl implements Model{
@Override @Override
public List<Result> getResult() throws ModelExcecutionException { public List<Result> getResult() throws ModelExcecutionException {
this.calculateTemperatureSum(DeliaRadicumModelDataMatrix.TMD, DeliaRadicumModelDataMatrix.TMDD); this.calculateTemperatureSum(DeliaRadicumModelDataMatrix.TMD, DeliaRadicumModelDataMatrix.TMDD4C);
if(this.dataMatrix.getFirstDateWithParameterValue(DeliaRadicumModelDataMatrix.TJM10D) != null) if(this.dataMatrix.getFirstDateWithParameterValue(DeliaRadicumModelDataMatrix.TJM10D) != null)
{ {
this.calculateTemperatureSum(DeliaRadicumModelDataMatrix.TJM10D, DeliaRadicumModelDataMatrix.TJM10DD); this.calculateTemperatureSum(DeliaRadicumModelDataMatrix.TJM10D, DeliaRadicumModelDataMatrix.TJM10DD4C);
} }
List<Result> results = new ArrayList<>(); List<Result> results = new ArrayList<>();
...@@ -98,11 +98,10 @@ public class DeliaRadicumModel extends I18nImpl implements Model{ ...@@ -98,11 +98,10 @@ public class DeliaRadicumModel extends I18nImpl implements Model{
{ {
Result result = new ResultImpl(); Result result = new ResultImpl();
result.setResultValidTime(currentDate); result.setResultValidTime(currentDate);
Double airTempSum = this.dataMatrix.getParamDoubleValueForDate(currentDate, DeliaRadicumModelDataMatrix.TMDD); Double airTempSum = this.dataMatrix.getParamDoubleValueForDate(currentDate, DeliaRadicumModelDataMatrix.TMDD4C);
result.setValue( result.setValue(CommonNamespaces.NS_WEATHER,
this.getModelId().toString(), DeliaRadicumModelDataMatrix.TMDD4C,
DeliaRadicumModelDataMatrix.TMDD,
dFormat.format(airTempSum) dFormat.format(airTempSum)
); );
...@@ -110,10 +109,9 @@ public class DeliaRadicumModel extends I18nImpl implements Model{ ...@@ -110,10 +109,9 @@ public class DeliaRadicumModel extends I18nImpl implements Model{
if(this.dataMatrix.getFirstDateWithParameterValue(DeliaRadicumModelDataMatrix.TJM10D) != null) if(this.dataMatrix.getFirstDateWithParameterValue(DeliaRadicumModelDataMatrix.TJM10D) != null)
{ {
soilTempSum = this.dataMatrix.getParamDoubleValueForDate(currentDate, DeliaRadicumModelDataMatrix.TJM10DD); soilTempSum = this.dataMatrix.getParamDoubleValueForDate(currentDate, DeliaRadicumModelDataMatrix.TJM10DD4C);
result.setValue( result.setValue(CommonNamespaces.NS_WEATHER,
this.getModelId().toString(), DeliaRadicumModelDataMatrix.TJM10DD4C,
DeliaRadicumModelDataMatrix.TJM10DD,
dFormat.format(soilTempSum) dFormat.format(soilTempSum)
); );
} }
...@@ -133,6 +131,14 @@ public class DeliaRadicumModel extends I18nImpl implements Model{ ...@@ -133,6 +131,14 @@ public class DeliaRadicumModel extends I18nImpl implements Model{
TJM10Obs != null ? dFormat.format(TJM10Obs.getValue()) : null TJM10Obs != null ? dFormat.format(TJM10Obs.getValue()) : null
); );
// Setting threshold values
result.setValue(this.getModelId().toString(), "TMDD4CLT", this.airTempSumLowerThreshold.toString());
result.setValue(this.getModelId().toString(), "TMDD4CUT", this.airTempSumUpperThreshold.toString());
if(this.dataMatrix.getFirstDateWithParameterValue(DeliaRadicumModelDataMatrix.TJM10D) != null)
{
result.setValue(this.getModelId().toString(), "TJM10DD4CLT", this.soilTempSumLowerThreshold.toString());
result.setValue(this.getModelId().toString(), "TJM10DD4CUT", this.soilTempSumUpperThreshold.toString());
}
// Determining warning status // Determining warning status
Integer warningStatus = Result.WARNING_STATUS_NO_RISK; Integer warningStatus = Result.WARNING_STATUS_NO_RISK;
if( ( soilTempSum != null && soilTempSum >= this.soilTempSumLowerThreshold) if( ( soilTempSum != null && soilTempSum >= this.soilTempSumLowerThreshold)
......
...@@ -27,8 +27,8 @@ import no.bioforsk.vips.util.DateMap; ...@@ -27,8 +27,8 @@ import no.bioforsk.vips.util.DateMap;
*/ */
public class DeliaRadicumModelDataMatrix extends DateMap{ public class DeliaRadicumModelDataMatrix extends DateMap{
// Aggregated values // Aggregated values
public final static String TMDD = "TMDD"; public final static String TMDD4C = "TMDD4C";
public final static String TJM10DD = "TJM10DD"; public final static String TJM10DD4C = "TJM10DD4C";
// Weather data stored for convenience (putting into result object) // Weather data stored for convenience (putting into result object)
public final static String TMD = "TMD"; public final static String TMD = "TMD";
public final static String TJM10D = "TJM10D"; public final static String TJM10D = "TJM10D";
......
...@@ -142,7 +142,7 @@ public class DeliaRadicumModelTest { ...@@ -142,7 +142,7 @@ public class DeliaRadicumModelTest {
for(Result result:results) for(Result result:results)
{ {
System.out.println(result.getResultValidTime() + ": " + result.getWarningStatus()); //System.out.println(result.getResultValidTime() + ": " + result.getWarningStatus());
if(result.getResultValidTime().compareTo(lastGreen) <= 0) if(result.getResultValidTime().compareTo(lastGreen) <= 0)
{ {
assertEquals(Result.WARNING_STATUS_NO_RISK, result.getWarningStatus()); assertEquals(Result.WARNING_STATUS_NO_RISK, result.getWarningStatus());
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment