Skip to content
Snippets Groups Projects
Commit cc3e74a1 authored by Tor-Einar Skog's avatar Tor-Einar Skog
Browse files

Handle user requesting a message with id that doesn't exist

parent f03a2cb4
Branches
No related tags found
No related merge requests found
...@@ -226,7 +226,11 @@ public class MessageController extends HttpServlet { ...@@ -226,7 +226,11 @@ public class MessageController extends HttpServlet {
request.setAttribute("allCropCategoryIds", em.createNamedQuery("CropCategory.findByOrganizationId").setParameter("organizationId",user.getOrganizationId().getOrganizationId()).getResultList()); request.setAttribute("allCropCategoryIds", em.createNamedQuery("CropCategory.findByOrganizationId").setParameter("organizationId",user.getOrganizationId().getOrganizationId()).getResultList());
request.getRequestDispatcher("/messageForm.ftl").forward(request, response); request.getRequestDispatcher("/messageForm.ftl").forward(request, response);
} }
catch(NullPointerException | NumberFormatException | NoResultException ex) catch(NoResultException ex)
{
response.sendError(404, "Message not found");
}
catch(NullPointerException | NumberFormatException ex)
{ {
response.sendError(500, ExceptionUtil.getStackTrace(ex)); response.sendError(500, ExceptionUtil.getStackTrace(ex));
} }
......
...@@ -976,8 +976,11 @@ public class LogicService { ...@@ -976,8 +976,11 @@ public class LogicService {
public Response getMessage(@PathParam("messageId") Integer messageId) public Response getMessage(@PathParam("messageId") Integer messageId)
{ {
Message message = messageBean.getMessage(messageId); Message message = messageBean.getMessage(messageId);
if(message != null)
return Response.ok().entity(message).build(); {
return Response.ok().entity(message).build();
}
return Response.status(Status.NOT_FOUND).build();
} }
/** /**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment