From 0cdac61686e3881c4916c189c92b264d295e70f0 Mon Sep 17 00:00:00 2001
From: Clara Anton Fernandez <caf@nibio.no>
Date: Wed, 10 May 2023 13:59:00 +0200
Subject: [PATCH] vol eq 2

---
 Volume_Norway_underbark.R | 46 ++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 25 deletions(-)

diff --git a/Volume_Norway_underbark.R b/Volume_Norway_underbark.R
index 9366f75..e570848 100644
--- a/Volume_Norway_underbark.R
+++ b/Volume_Norway_underbark.R
@@ -10,41 +10,37 @@ function (dbh.mm, height.dm, tree.sp)
         }
         x
     }
-    
+    if (any(is.na(height.dm))) stop("some heights are NA")
     if (any(dbh.mm < 50)) 
         stop("all dbh.mm should be at least 50mm")
     
-    i.tree.sp.1 <- num.species %in% c("Norway spruce")
-    i.tree.sp.2 <- num.species %in% c("Scots Pine")
-    i.tree.sp.3 <- num.species %in% c("Other Conif")
-    i.tree.sp.4 <- num.species %in% c("Hardwoods")
-    if ((sum(i.tree.sp.1) + sum(i.tree.sp.2) + sum(i.tree.sp.3) + 
-        sum(i.tree.sp.4)) != length(num.species)) {
-        print(num.species[which(!i.tree.sp.1 & !i.tree.sp.2 & 
+    i.tree.sp.1 <- tree.sp %in% c("Norway spruce")
+    i.tree.sp.3 <- tree.sp %in% c("Scots pine", "Other Conif")
+    i.tree.sp.4 <- tree.sp %in% c("Hardwoods")
+    if ((sum(i.tree.sp.1) +  sum(i.tree.sp.3) + 
+        sum(i.tree.sp.4)) != length(tree.sp)) {
+        print(tree.sp[which(!i.tree.sp.1 &
             !i.tree.sp.3 & !i.tree.sp.4)])
         stop("some species are not recognized")
     }
     vol.wo.bark.l <- rep(NA, length(dbh.mm))
 
     ## under bark
-       
-    vol.wo.bark.l[ i.tree.sp.1] <- picea.abies.vol(dbh = dbh.mm[i12], 
-            trh = height.dm[i12], bark = "ub", units = "l") * 
-            (1 - (nvl(vol.reduksjon[i12], 0)/100))
-    vol.wo.bark.l[i.tree.sp.2] <- sitka.vol(dbh = dbh.mm[i.tree.sp.2], 
-            trh = height.dm[i.tree.sp.2], bark = "ub", units = "l") * 
-            (1 - (nvl(vol.reduksjon[i.tree.sp.2], 0)/100))
-       
-    vol.wo.bark.l[i.tree.sp.3] <- pinus.sylvestris.vol(dbh = dbh.mm[i32], 
-            trh = height.dm[i32], bark = "ub", units = "l") * 
-            (1 - (nvl(vol.reduksjon[i32], 0)/100))
-    vol.wo.bark.l[i.tree.sp.4] <- harw.nor.vol(tsl = as.integer(tree.sp[i.tree.sp.4]), 
-            dbh = dbh.mm[i.tree.sp.4], trh = height.dm[i.tree.sp.4], 
-            bark = "ub", units = "l") * (1 - (nvl(vol.reduksjon[i.tree.sp.4], 
-            0)/100))
-    
-    volume.norway <- list()
+
+    vol.wo.bark.l[ i.tree.sp.1] <- picea.abies.vol(dbh = dbh.mm[i.tree.sp.1], 
+            trh = height.dm[i.tree.sp.1], bark = "ub", units = "l")     
+    vol.wo.bark.l[i.tree.sp.3] <-
+      pinus.sylvestris.vol(dbh = dbh.mm[i.tree.sp.3], 
+                           trh = height.dm[i.tree.sp.3],
+                           bark = "ub", units = "l")
+    ## assuming all hardwoods are birch
+    vol.wo.bark.l[i.tree.sp.4] <- harw.nor.vol(tsl = rep(30, sum(i.tree.sp.4)) ,
+                                               dbh = dbh.mm[i.tree.sp.4],
+                                               trh = height.dm[i.tree.sp.4], 
+                                               bark = "ub", units = "l") 
+
     
     vol.wo.tr.m3 <- vol.wo.bark.l/1000
+  
     return(vol.wo.tr.m3)
 }
-- 
GitLab